search

c4dt / lightarti-rest

Arti-wrapper to use REST over Tor
MIT License
5 stars 3 forks source link

Churn handling #67

Closed laurent-girod closed 3 years ago

laurent-girod commented 3 years ago

Implement mechanism to handle churned routers in a customized consensus.

tharvik commented 3 years ago

I propose you already work on these changes, and we wait for @tharvik's return next week to have another look at the rust part.

We are next week, what can I help you with?

ineiti commented 3 years ago

We are next week, what can I help you with?

Look at the rust part - I tried to cover some of the if / match branches that I know how to simplify, but there might be others.

@laurent-girod is there a way to show what you changed in the imported files from tor-netdoc?

@laurent-girod and you'll need to rebase from main.

tharvik commented 3 years ago

Needs a rebase on main.

Isn't a squash commit better? It also avoid to add and then remove many copied lines.

ineiti commented 3 years ago

Interesting - it cannot be rebased, but squash and merge is possible. My idea was to:

but the first step doesn't seem necessary. Let's discuss after the DCL-meeting.