Optimizations and Bugfixes

c4ev3 / ev3duder

The LEGO® EV3 Downloader/UploaDER.

http://c4ev3.github.io/ev3duder/doc/html/globals_func.html

GNU General Public License v3.0

32 stars 12 forks source link

Optimizations and Bugfixes #8

Closed dnlmlr closed 6 years ago

dnlmlr commented 6 years ago

Changed the hidlib backend on linux from libusb-1.0 to hidraw, to fix an upload bug on linux.
Changed the help function (--help) to be more helpful.
Made some minor optimizations to readability and the code itself.

a3f commented 6 years ago

You can git push --force to your feature branch and Github will update the existing pull request, by the way. I will try to look through the patches this weekend. Thanks. :)

dnlmlr commented 6 years ago

Sorry I had to redo this pull request, but I needed to change some wrong metadata in my commits. The actual commits are the same.

dnlmlr commented 6 years ago

Yea I know about git push --force, but for some reason it did not work in this case. It did do the push, but for some reason the metadata did not change when cloning/pulling it again.

a3f commented 6 years ago

Thanks. I rewrote some of the commits; The stray s after the #include would've broken git bisect, so I amended that commit. Same goes for the removed and re-added EV3-API submodule. The rest are some minor stylistic issues.

I don't format my code like I did three years ago, so thanks for fixing that too. :)