git:// --> https:// for v8-profiler dependency

c4milo / node-webkit-agent

NodeJS agent for WebKit devtools front-end

http://c4milo.github.io/node-webkit-agent/

1.1k stars 128 forks source link

git:// --> https:// for v8-profiler dependency #10

Closed nemtsov closed 10 years ago

nemtsov commented 12 years ago

For us—poor souls behind a proxy—can you please switch to using: https://github.com/c4milo/v8-profiler.git (as opposed to git://) in the profile.json

c4milo commented 12 years ago

sadly, npm doesn't work if I do this change :(

nemtsov commented 12 years ago

That is unfortunate. Do you think it's worth releasing your fork as "v8-profiler-4-webkit-devtools-agent" on npm? That also has the added advantage of locking-in a specific version of the v8-profiler into a version of the devtools.

c4milo commented 12 years ago

I was thinking to include in node-webkit-agent only the specific functions it's using from v8-profiler, since they are really few. As for your current issue, indeed, publishing in npm under a different name make sense for now. I'll do that as soon as I can have some spare time.

On Wed, Jun 20, 2012 at 3:28 PM, Yuriy Nemtsov < reply@reply.github.com

wrote:

That is unfortunate. Do you think it's worth releasing your fork as "v8-profiler-4-webkit-devtools-agent" on npm? That also has the added advantage of locking-in a specific version of the v8-profiler into a version of the devtools.

Reply to this email directly or view it on GitHub: https://github.com/c4milo/node-webkit-agent/issues/10#issuecomment-6464542

Camilo Aguilar Software Engineer

c4milo commented 11 years ago

@nemtsov, do you still need this?

nemtsov commented 11 years ago

I'm using my local fork, so—not desperately :) But I'd love to switch to your version.

c4milo commented 11 years ago

hehe, smart. I'm just wondering if npm is now able to pull http dependencies. I'll test that again and keep you posted.