Update package.json

[polidore]

Using https git urls in dependencies to make this work from behind corporate firewall.

[c4milo]

I remember I was holding up this change because NPM didn't work well with http based dependencies. What node and npm versions did you use to test?

[polidore]

Test? Sorry about that. I toyed around with it this AM and I think it is working now on

~/3rd/node-webkit-agent(branch:patch-1) » node --version                                  
v0.10.20

~/3rd/node-webkit-agent(branch:patch-1) » npm --version                                   
1.3.11

~/3rd/node-webkit-agent(branch:patch-1*) » npm install                                    
npm http GET https://registry.npmjs.org/ws/0.4.25
npm http GET https://registry.npmjs.org/should/0.6.0
npm http GET https://registry.npmjs.org/underscore/1.3.3
npm http GET https://registry.npmjs.org/mocha/0.14.1
npm http 304 https://registry.npmjs.org/underscore/1.3.3
npm http 304 https://registry.npmjs.org/mocha/0.14.1
npm http 304 https://registry.npmjs.org/ws/0.4.25
npm http 304 https://registry.npmjs.org/should/0.6.0
npm WARN engine mocha@0.14.1: wanted: {"node":">= 0.4.x < 0.8.0"} (current: {"node":"v0.10.20","npm":"1.3.11"})

> v8-profiler@4.0.0 install /home/bpolidor/3rd/node-webkit-agent/node_modules/v8-profiler
> node-gyp rebuild

npm http GET https://registry.npmjs.org/tinycolor
npm http GET https://registry.npmjs.org/jade/0.20.3
npm http GET https://registry.npmjs.org/commander
npm http GET https://registry.npmjs.org/commander
npm http GET https://registry.npmjs.org/growl
npm http GET https://registry.npmjs.org/diff/1.0.2
npm http GET https://registry.npmjs.org/options
npm http GET https://registry.npmjs.org/debug
npm http 304 https://registry.npmjs.org/tinycolor
npm http 200 https://registry.npmjs.org/jade/0.20.3
npm http GET https://registry.npmjs.org/jade/-/jade-0.20.3.tgz
npm http 304 https://registry.npmjs.org/commander
npm http 304 https://registry.npmjs.org/commander
npm http GET https://registry.npmjs.org/commander/-/commander-0.5.2.tgz
npm http 304 https://registry.npmjs.org/growl
npm http 304 https://registry.npmjs.org/options
npm http 304 https://registry.npmjs.org/diff/1.0.2
npm http 304 https://registry.npmjs.org/debug
npm http 200 https://registry.npmjs.org/jade/-/jade-0.20.3.tgz
npm http 200 https://registry.npmjs.org/commander/-/commander-0.5.2.tgz

> ws@0.4.25 install /home/bpolidor/3rd/node-webkit-agent/node_modules/ws
> (node-gyp rebuild 2> builderror.log) || (exit 0)

npm WARN excluding symbolic link lib/index.js -> jade.js
make: Entering directory `/home/bpolidor/3rd/node-webkit-agent/node_modules/v8-profiler/build'
  CXX(target) Release/obj.target/profiler/cpu_profiler.o
npm http GET https://registry.npmjs.org/mkdirp
make: Entering directory `/home/bpolidor/3rd/node-webkit-agent/node_modules/ws/build'
  CXX(target) Release/obj.target/bufferutil/src/bufferutil.o
npm http 200 https://registry.npmjs.org/mkdirp
  CXX(target) Release/obj.target/profiler/heap_profiler.o
  SOLINK_MODULE(target) Release/obj.target/bufferutil.node
  CXX(target) Release/obj.target/profiler/profile.o
  SOLINK_MODULE(target) Release/obj.target/bufferutil.node: Finished
  COPY Release/bufferutil.node
  CXX(target) Release/obj.target/validation/src/validation.o
  CXX(target) Release/obj.target/profiler/profile_node.o
  CXX(target) Release/obj.target/profiler/profiler.o
  SOLINK_MODULE(target) Release/obj.target/validation.node
  SOLINK_MODULE(target) Release/obj.target/validation.node: Finished
  COPY Release/validation.node
make: Leaving directory `/home/bpolidor/3rd/node-webkit-agent/node_modules/ws/build'
  CXX(target) Release/obj.target/profiler/snapshot.o
  SOLINK_MODULE(target) Release/obj.target/profiler.node
  SOLINK_MODULE(target) Release/obj.target/profiler.node: Finished
  COPY Release/profiler.node
make: Leaving directory `/home/bpolidor/3rd/node-webkit-agent/node_modules/v8-profiler/build'

> v8-profiler@4.0.0 postinstall /home/bpolidor/3rd/node-webkit-agent/node_modules/v8-profiler
> ln -sf build/Release/profiler.node profiler.node

should@0.6.0 node_modules/should

underscore@1.3.3 node_modules/underscore

mocha@0.14.1 node_modules/mocha
├── commander@0.5.2
├── growl@1.5.1
├── debug@0.7.2
├── diff@1.0.2
└── jade@0.20.3 (mkdirp@0.3.5)

ws@0.4.25 node_modules/ws
├── tinycolor@0.0.1
├── options@0.0.5
└── commander@0.6.1

v8-profiler@4.0.0 node_modules/v8-profiler
------------------------------------------------------------

[danmactough]

@c4milo Why not see if @dannycoates will take a pull request to or publish your fork on npm?

[c4milo]

@danmactough he stopped supporting v8-profiler a year ago. I also remember, in a node conference, he encouraging people to use node-webkit-agent for cpu/memory profiling and node-inspector for debugging. That makes me believe he is not really interested in continuing maintaining v8-profiler. Additionally, my fork of v8-profiler is only intended to work for node-webkit-agent and I'm not entirely sure if my modifications will be useful outside of node-webkit-agent.

[danmactough]

@c4milo If it won't work generally, then I think you should just make it part if this module. It's horrible when you can't npm install something when github is down because of a github url in package.json.

[c4milo]

True. I was planning on doing that but I got caught up in other things :/

[danmactough]

Maybe someone can fix that for you. :)

[c4milo]

that is the hope :)

[c4milo]

This is fully addressed in b3c749af49ff263317364b60785ae49c1c527ee4 and version 0.2.0 in NPM.

[c4milo]

Thanks @danmactough!