search

c4milo / node-webkit-agent

NodeJS agent for WebKit devtools front-end
http://c4milo.github.io/node-webkit-agent/
1.09k stars 78 forks source link

startProfiling and stopProfiling should agree on the default name #55

Open bpytlik opened 10 years ago

bpytlik commented 10 years ago

In v8-profiler.js it seems like startProfiling sets the default name to be

name = 'org.nodejs.profiles.cpu.user-initiated.' + (cpuCache.length + 1);

Meanwhile, stopProfiling sets the default name to be ''.

It seems like those should be consistent. I'm still wrapping my head around how everything fits together though, so please correct me if I'm confused.

bpytlik commented 10 years ago

I think the above is especially true given the implementation in profiler.js where profiler.startProfiling and profiler.stopProfiling are both called without arguments. Fixing issue #52 might resolve this issue.

c4milo commented 10 years ago

I'm not sure I understand the issue you are trying to solve.