Open maxmil7 opened 9 years ago
yes, I need to catch up now. Thanks for the issue report.
+1
This is being addressed in https://github.com/c4milo/node-webkit-agent/pull/79
+1
Addressed by https://github.com/c4milo/node-webkit-agent/pull/79, CPU profiling is not working yet though.
Do you expect there will be movement on this issue any time soon? I like node-webkit-agent and would feel sad to switch, but this is a blocker for us upgrading to Node v0.12.
@macinjosh32 master branch has a working version for Node v0.12.x. Although, there wouldn't be CPU profiler, it is the last piece missing to get full support for 0.12.x.
using 0.12.5 version of node -> npm install webkit-devtools-agent@0.3.1 gives the below error
ws@0.4.31 install /Users/shegde6/nodeapps/SampleApp/node_modules/webkit-devtools-agent/node_modules/ws (node-gyp rebuild 2> builderror.log) || (exit 0)
CXX(target) Release/obj.target/bufferutil/src/bufferutil.o
webkit-devtools-agent@0.3.1 install /Users/shegde6/nodeapps/SampleApp/node_modules/webkit-devtools-agent node-gyp rebuild
CXX(target) Release/obj.target/profiler/src/cpu_profiler.o
In file included from ../src/cpu_profiler.cc:1:
../src/cpu_profiler.h:19:57: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle~~~~
v8::internal::Arguments
/Users/shegde6/.node-gyp/0.12.5/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
^
In file included from ../src/cpu_profiler.cc:1:
../src/cpu_profiler.h:20:51: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle~~~~
v8::internal::Arguments
/Users/shegde6/.node-gyp/0.12.5/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
^
In file included from ../src/cpu_profiler.cc:1:
../src/cpuprofiler.h:21:52: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle~~~~
v8::internal::Arguments
/Users/shegde6/.node-gyp/0.12.5/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
..............................................
/Users/shegde6/.node-gyp/0.12.5/src/node.h:228:13: note: candidate function [with TypeName = v8::Localv8::Object] not viable: no known
conversion from 'Handlev8::Value (const v8::internal::Arguments &)' to 'v8::FunctionCallback' (aka 'void (make
failed with exit code: 2
@sandeshhegde83, did you ever resolve this? I'm running into the exact same issue, so if there is a known solution it would be great if you could share it :+1:
I'm sorry you guys are running into these issues. Unfortunately, I haven't found time to work on this, but I would be happy to help if anyone of you want to tackle this problem.
+1
npm install webkit-devtools-agent /
CXX(target) Release/obj.target/bufferutil/src/bufferutil.o
child_process: customFds option is deprecated, use stdio instead. CXX(target) Release/obj.target/profiler/src/cpu_profiler.o In file included from ../src/cpu_profiler.cc:1: ../src/cpu_profiler.h:19:57: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'? static Handle GetProfilesCount(const Arguments& args);
^ GetProfile(const Arguments& args);
^ FindProfile(const Arguments& args);
^ StartProfiling(const Arguments& args);
^ StopProfiling(const Arguments& args);
^ DeleteAllProfiles(const Arguments& args);
^ GetUid(Local property, const AccessorInfo& info);
^
../src/profile.h:17:63: error: unknown type name 'AccessorInfo'
static Handle GetTitle(Local property, const AccessorInfo& info);
^
../src/profile.h:18:65: error: unknown type name 'AccessorInfo'
static Handle GetTopRoot(Local property, const AccessorInfo& info);
^
../src/profile.h:19:68: error: unknown type name 'AccessorInfo'
static Handle GetBottomRoot(Local property, const AccessorInfo& info);
^
../src/profile.h:20:37: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle Delete(const Arguments& args);
^::New(ObjectTemplate::New());
^
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:572:23: note: declared private here
V8_INLINE static T* New(Isolate* isolate, T* that);
^
../src/cpu_profiler.cc:10:34: error: too few arguments to function call, expected 2, have 1; did you mean 'Profile::New'?
cpu_profilertemplate = Persistent::New(ObjectTemplate::New());
^ New(const CpuProfile* profile);
^
../src/cpu_profiler.cc:11:31: error: member reference type 'Persistentv8::ObjectTemplate' is not a pointer; maybe you meant to use '.'?
cpu_profilertemplate->SetInternalFieldCount(1);
~~~~ v8::internal::Arguments /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; ^ In file included from ../src/cpu_profiler.cc:1: ../src/cpu_profiler.h:20:51: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'? static Handle~~~~ v8::internal::Arguments /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; ^ In file included from ../src/cpu_profiler.cc:1: ../src/cpu_profiler.h:21:52: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'? static Handle~~~~ v8::internal::Arguments /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; ^ In file included from ../src/cpu_profiler.cc:1: ../src/cpu_profiler.h:22:55: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'? static Handle~~~~ v8::internal::Arguments /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; ^ In file included from ../src/cpu_profiler.cc:1: ../src/cpu_profiler.h:23:54: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'? static Handle~~~~ v8::internal::Arguments /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; ^ In file included from ../src/cpu_profiler.cc:1: ../src/cpu_profiler.h:24:58: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'? static Handle~~~~ v8::internal::Arguments /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; ^ In file included from ../src/cpu_profiler.cc:2: ../src/profile.h:16:61: error: unknown type name 'AccessorInfo' static Handle~~~~ v8::internal::Arguments /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; ^ ../src/cpu_profiler.cc:8:21: error: calling a protected constructor of class 'v8::HandleScope' HandleScope scope; ^ /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:816:13: note: declared protected here V8_INLINE HandleScope() {} ^ ../src/cpu_profiler.cc:10:62: error: 'New' is a private member of 'v8::PersistentBasev8::ObjectTemplate' cpu_profilertemplate = Persistent~~~~~~Profile::New ../src/profile.h:13:24: note: 'Profile::New' declared here static Handle