search

c4milo / node-webkit-agent

NodeJS agent for WebKit devtools front-end
http://c4milo.github.io/node-webkit-agent/
1.1k stars 128 forks source link

Serve the devtools client from the proxy rather than hosting elsewhere #82

Closed mildmojo closed 5 years ago

mildmojo commented 9 years ago

How do you feel about serving the devtools front end from the agent proxy, similar to what node-inspector does?

By serving the front end on the same port as the websockets proxy, the tools URL looks like: http://localhost:9999/inspector.html?host=localhost:9999&page=0

For clarity, I've split the branch into two commits. 17ef6bc is the one with code changes to serve the tools.

I made this change in a project where I had to vendor node-webkit-agent because it was unacceptable for developers to access the devtools front end elsewhere for security and usability reasons. It uses the 26.0.1410.65 front end from the gh-pages branch. The example here works for me, but might need a little work to use a different front end for older node versions. Thoughts?

c4milo commented 9 years ago

Hey @mildmojo, I certainly don't mind this but I would like to wait to see if more people want to weigh in before merging. Thanks for your PR!

mildmojo commented 5 years ago

Seems like this project is superseded by node --inspect and Chrome devtools, so I'm closing this to clean up my personal dashboard.