c4urself / bump2version

Version-bump your software with a single command
https://pypi.python.org/pypi/bump2version
MIT License
1.06k stars 134 forks source link

Add test requirements including minimal versions #143

Closed sebix closed 3 years ago

ekohl commented 4 years ago

Any thoughts on this? I also think that 6.0.0 is not entirely correct. From the changelog:

LogCapture.actual() is now part of the documented public interface.

However, the class is much older. 1.2.0 mentions that LogCapture can now do some things, which means the class has always been there.

I think this can be closed.

florisla commented 3 years ago

The preferred way to do this in setup.py is to use extras_require.

extras_require={
    'test': ['pytest>=3.4.0']
}
sebix commented 3 years ago

As requested, I changed the testfixtures version to 1.2.0 and tests_require to extras_require

florisla commented 3 years ago

Hi,

The required version of testfixtures in tox.ini differs versus setup.py. Any particular reason?

Could you squash your three commits into one? We don't need the test_require commits.

florisla commented 3 years ago

I'm OK with putting this 'feature' in.

It's not the official testing strategy (that's Tox, and CI) but this is more light-weight and can be handy for contributors.

sebix commented 3 years ago

I think I incorporated all requested changes now

florisla commented 3 years ago

Thanks!