c4urself / bump2version

Version-bump your software with a single command
https://pypi.python.org/pypi/bump2version
MIT License
1.06k stars 134 forks source link

support glob keyword in configfile #150

Closed balrok closed 4 years ago

balrok commented 4 years ago

This implements https://github.com/c4urself/bump2version/issues/64

balrok commented 4 years ago

thanks for your comments in both PR :-) having the VersionConfig created outside of the loop will also reuse the object between the globbed-files

ekohl commented 4 years ago

having the VersionConfig created outside of the loop will also reuse the object between the globbed-files

Yes. I think that's good because it only sets variables in the constructor, not at runtime. This saves some resources.

balrok commented 4 years ago

just one small fix, I was not aware that python-glob does not interpret "**" by default as recursive.. one has to set the recursive-flag in this function before.. there is now also a test for this

ekohl commented 4 years ago

Thanks @balrok!

lowell80 commented 3 years ago

Awesome feature, thanks @balrok! You just saved me a bunch of time!