search

c4urself / bump2version

Version-bump your software with a single command
https://pypi.python.org/pypi/bump2version
MIT License
1.06k stars 134 forks source link

Not require to rewrite full cfg-file when bumping the version #163

Open balrok opened 4 years ago

balrok commented 4 years ago

Since pr #90 introduced a lot of breaking changes (can bee seen in the updated unit tests in #162 ). Here is another approach. Basically it makes it opt-in to use bump2version on the .bumpversion.cfg rather than the opt-out approach of #90.

When this PR is merged it solves #87, #62, and provides a solution for #161

balrok commented 3 years ago

What do you think? It is not breaking existing tools while having finally a way to write comments into the cfg-file. This is especially important if the file is used to configure other tools too.

yakky commented 3 years ago

@balrok If I understand correctly your patch will avoid bump2version to update the config file, and one has to rely on the explicit configuration which will only update the version string via _replace_version_in_files instead of _update_config_file which rewrites the whole configuration file This looks a smart move. The only concern is that it's not 100% compatible as one has to change its configuration to retain the current behavior (even for people not affected by the current behavior)

simonmoesorensen commented 1 year ago

I know it's not great to revive dead threads, but is this PR going to get merged in the future? My team is having issues with pre-commit and bump2version as in #124