search

c4urself / bump2version

Version-bump your software with a single command
https://pypi.python.org/pypi/bump2version
MIT License
1.05k stars 134 forks source link

--dry-run only works if verbose logging is turned on #179

Open chris-w-jarvis opened 3 years ago

chris-w-jarvis commented 3 years ago

Hello,

This is just an ease of use thing that I noticed when using bump2version the first time:

❯❯❯ bump2version --current-version 2.0.6 minor --dry-run
❯❯❯ bump2version --current-version 2.0.6 minor --dry-run --verbose
Reading config file setup.cfg:
[easy_install]
index-url=https://pypi.apple.com/simple

Attempting to increment part 'minor'
Values are now: major=2, minor=1, patch=0
Dry run active, won't touch any files.
New version will be '2.1.0'
... full dry run output continues ...

I would be happy to make this change but I wanted to know first if there is a reason for this behavior or if there is any reason you wouldn't want this change. Thanks!

chris-w-jarvis commented 3 years ago

maybe this isn't really an issue because the point of dry-run is to not do anything, not necessarily to print logging output. But then the command isn't exactly useful without the verbose option. What do you think? Feel free to close this, thanks.

florisla commented 3 years ago

To clarify, you propose to make --dry-run do the same as --dry-run --verbose does now?

That sounds like a good idea to me. I guess the only other use case for --dry-run is to see if it fails (produces a warning or has a non-zero exit status).

chris-w-jarvis commented 3 years ago

Yes! That is a much more concise way to put it :)