search

c4urself / bump2version

Version-bump your software with a single command
https://pypi.python.org/pypi/bump2version
MIT License
1.05k stars 135 forks source link

Configuration for github actions #229

Closed clbarnes closed 2 years ago

clbarnes commented 2 years ago

See #227

ekohl commented 2 years ago

I briefly pushed the branch to upstream which triggers the tests to actually run.

clbarnes commented 2 years ago

Thanks! MacOS fails because the image doesn't have mercurial in it by default. Other than that, seems to be passing on my side!

Before un-drafting this, I'll remove the appveyor and travis configs and add py39.

ekohl commented 2 years ago

Just so you're aware of it: I now need to approve and run every time to actually run.

Could you also give it a name at the top level? That way we don't see the the filename but rather something nice. You can add name: CI at the very top.

clbarnes commented 2 years ago

Don't worry about approving it so it can run here, I'm checking on my own branch and will un-draft when it's passing there. Working on the last failures!

clbarnes commented 2 years ago

Green on my end. py39's argparse apparently formats differently to others', so I had to normalise the whitespace when doing string containment checks on those messages.

ekohl commented 2 years ago

Perhaps you can squash the commits and leave out the Python 3.9 changes? Then I'd have no problem merging it but I don't have time to look at the 3.9 changes that closely.

clbarnes commented 2 years ago

Rebased, updated the readme buttons, noted it in the changelog, and squashed. It's weird that appveyor is still doing anything; the repo doesn't have any mentions of it outside of the changelog. Maybe the repo is still registered on the appveyor side? It looks like the failure is that it can't find the config file, which is good at least.

ekohl commented 2 years ago

@florisla this has been open for a long time. Any reason we can't merge this?

florisla commented 2 years ago

Much appreciated @clbarnes, this is great work!