I was checking that bump2version works as expected for my use case. Currently, I want to handle the tagging step myself. So, I'm running commands like bumpversion --dry-run --verbose major against the following config file:
The part of the output that tripped me up at first is Would tag 'v1.0.0' with message 'Bump version: 0.1.4 → 1.0.0' in Mercurial and not signing. This is... probably technically correct, but I find it kind of confusing in this case.
The relevant lines in the cli.py file are do_tag = args.tag and not args.dry_run and "Would tag" if not do_tag else "Tagging",. I'm not yet sure what phrasing I'd like to see, but I feel like the current phrasing doesn't communicate whether it hits "Would tag" because args.tag is False, args.dry_run is True, or both.
I guess what I'm wondering is whether there's value in emitting that log line at all when args.tag is False.
I was checking that bump2version works as expected for my use case. Currently, I want to handle the tagging step myself. So, I'm running commands like
bumpversion --dry-run --verbose major
against the following config file:The part of the output that tripped me up at first is
Would tag 'v1.0.0' with message 'Bump version: 0.1.4 → 1.0.0' in Mercurial and not signing
. This is... probably technically correct, but I find it kind of confusing in this case.The relevant lines in the
cli.py
file aredo_tag = args.tag and not args.dry_run
and"Would tag" if not do_tag else "Tagging",
. I'm not yet sure what phrasing I'd like to see, but I feel like the current phrasing doesn't communicate whether it hits "Would tag" becauseargs.tag
is False,args.dry_run
is True, or both.I guess what I'm wondering is whether there's value in emitting that log line at all when
args.tag
is False.