stampedeboss
commented
2 years ago In the future I will pull out the version bumping, and yes it conflicts with allow_dirty. I thought about adding another parameter that was mutually exclusive with allow dirty. If you are making a commit of the version files, it doesn't make sense to me not to commit the tracked files, tags really become worthless since all the code is not present in the library. AJ Reynolds
On Mon, Mar 14, 2022 at 5:26 AM Ewoud Kohl van Wijngaarden < @.***> wrote:
@.**** requested changes on this pull request.
Could you please leave out the version bumping?
I also wonder about this feature. It makes the allow_dirty option kind of pointless, doesn't it? Should this be default behavior or something to opt into?
— Reply to this email directly, view it on GitHub https://github.com/c4urself/bump2version/pull/245#pullrequestreview-908572334, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB64OVPKC5QQVKKX3OSZVNLU74H3ZANCNFSM5QT4UZKQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
Extends the lists of files to be commited to include all files being tracked.