Docker release - Githubissues

AlphaGit commented 3 years ago

(This PR superseeds https://github.com/Coalfire-Research/npk/pull/62)

Added a dockerfile that builds a docker image to use npk. This provides the benefit for users to run npk through a single command line.

This prevents everyone from dealing with multiple terraform, python, pip and node versions that do not quite work together.

Could be done in a future enhancement:

Add ARGs, ENVs or a startup script (á la MySQL) so that the container can setup the aws credential profile when running and does not need to be a manual process.
Add ARG, ENVs or a startup script (á la MySQL) so that the container can setup the /npk/terraform/npk-settings.json file and does not need to be a manual process.
After these are done, we can remove nano (or any text editor) being installed, making the image smaller and faster to create.

I decided to keep these changes out since this version is currently functional and only requires users to edit text files. This can also be done by mounting a volume in the right directory, but this feels more like user documentation than a feature to be built.

c6fc commented 3 years ago

I actually already pulled this PR across from CoalfireLabs repo and merged this into the dev branch. I'm pretty sure I managed to retain you as the contributor as well. I just moved it to main - thanks for the contribution.

c6fc commented 3 years ago

If you want to commit the optimizations you made, feel free to re-open against the dev branch to avoid conflicts

AlphaGit commented 3 years ago

Ah, cool! Thank you! Not sure how I missed it. I'll take a look and I might create that PR with the small optimization -- but they're not mostly trivial.

Thank you!

c6fc / npk

Docker release #5