search

c9 / architect

A simple yet powerful plugin system for large-scale node applications
MIT License
982 stars 129 forks source link

Error after upgrade #19

Closed aledbf closed 11 years ago

aledbf commented 11 years ago

I'm trying to update architect from 0.1.8 to 0.1.10 I get this error: TypeError: Cannot assign to read only property 'name' of function ....

Here is a small project (just one plugin) that reproduce the error https://github.com/aledbf/architect-upgrade-type-error.git

Any idea? Thanks

nightwing commented 11 years ago

seems to be caused by https://github.com/c9/architect/commit/3ac62c48503b3e8f2ced23c9faaa38579b46594f could you test with that two lines removed?

aledbf commented 11 years ago

Yes, It works fine

aledbf commented 11 years ago

Is there any particular reason why is expected an object and no other thing?

nightwing commented 11 years ago

no reason, just that non configurability of function names is easy to overlook.

cayasso commented 11 years ago

So is this going to be fixed or not? I do still see the issue.

nightwing commented 11 years ago

fixed by https://github.com/c9/architect/pull/22