c9 / architect

A simple yet powerful plugin system for large-scale node applications
MIT License
981 stars 129 forks source link

`serviceReady` never fires of no consumes/provides #3

Closed cadorn closed 12 years ago

cadorn commented 12 years ago

If no consumes/provides are used in loaded plugins the serviceReady event never fires causing the boot sequence to never finish.

creationix commented 12 years ago

Could you give an example of this? Is this the case there there are no services in the entire system?

creationix commented 12 years ago

The event system is much simpler now. There are three events. "service", "plugin", and "ready". The logic was changed to account for the zero case as well.

https://github.com/c9/architect/blob/e6df04ae3ff9076911ca4da4ba1de9acaccdfc68/architect.js#L161-163