Redundant usage of `sudo` in some docs

c9 / docs.c9.io

The documentation. For Cloud9 IDE.

89 stars 60 forks source link

Redundant usage of `sudo` in some docs #158

Closed muru closed 9 years ago

muru commented 9 years ago

The commands in the PostgreSQL guide are using sudo twice, unnecessarily, IMHO:

sudo sudo -u psql ...

Either:

The user has been limited to sudo -u psql * via sudo, in which they might as well be granted rights to run as psql in sudoers directly,
Or they can run pretty much anything since granting access to root's sudo via sudo is pointless as a restriction.

I think this is more of a typo or an oversight than anything else.

muru commented 9 years ago

Ok, guess I'm not too familiar with pull requests. Sorry for the extra spam.

bradydowling commented 9 years ago

Wow, not sure how we got sudo in there twice but good catch! And no problem on the pull request mixup, it's a bit tricky at first.

Go to your own repo, the forked version of this one
Click on the green button in the top left
On the next page make sure you select this repo as the base fork and your repo as the head fork

This should do it for you but if there are further issues, feel free to reach out again and maybe a pull request doc would be a good thing to make for all Cloud9 users. The changes you made look great though, thanks again for the PR. I'll be happy to merge them in once you do that!