c9 / install

Cloud9 SSH installer
179 stars 151 forks source link

MacOS tmux install error #101

Open glingy opened 5 years ago

glingy commented 5 years ago

When installing on MacOS Mojave, the installer downloads tmux through homebrew, but it installs version 2.8. In the script, it checks that tmux is between 1.9 and 2.2, so the installer never passes. I added @2.2 on the brew install line of the script:

370: brew install tmux@2.2 > /dev/null || (brew remove tmux &>/dev/null && brew install tmux@2.2 >/dev/null)
371: ln -sf "$(which tmux)" "$C9_DIR"/bin/tmux

However, this does not work because homebrew does not have a version 2.2 of tmux. Should I install 2.8 and override the restrictions?

if [ "$("$PYTHON" -c "print 1.7<=$tmux_version and $tmux_version <= 2.2")" == "True" ]; then
  return 0
else
  return 1
fi

It seems to have worked (replace 2.2 with 2.8 in the version max), but I wanted to post this in case others are having this problem.