c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.18k stars 283 forks source link

FEATURE: [INDICATOR] keltner channel #1522

Closed michaljirman closed 7 months ago

michaljirman commented 7 months ago

adding a simple keltner channel indicator implementation

bbgokarma-bot commented 7 months ago

Hi @michaljirman,

This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development.

This pull request may get 275 BBG.

To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG tokens will be transferred to your wallet.

-- If you're interested in our project, feel free to join our Telegram group https://t.me/bbgo_intl

Best, KarmaBot

codecov[bot] commented 7 months ago

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (80ed46e) 21.78% compared to head (825be2a) 21.76%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1522/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1522?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1522 +/- ## ========================================== - Coverage 21.78% 21.76% -0.02% ========================================== Files 605 606 +1 Lines 43874 43913 +39 ========================================== Hits 9557 9557 - Misses 33635 33674 +39 Partials 682 682 ``` | [Files](https://app.codecov.io/gh/c9s/bbgo/pull/1522?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) | Coverage Δ | | |---|---|---| | [pkg/bbgo/indicator\_set.go](https://app.codecov.io/gh/c9s/bbgo/pull/1522?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL2JiZ28vaW5kaWNhdG9yX3NldC5nbw==) | `48.14% <0.00%> (-1.86%)` | :arrow_down: | | [pkg/indicator/v2/keltner.go](https://app.codecov.io/gh/c9s/bbgo/pull/1522?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL2luZGljYXRvci92Mi9rZWx0bmVyLmdv) | `0.00% <0.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1522?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1522?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [80ed46e...825be2a](https://app.codecov.io/gh/c9s/bbgo/pull/1522?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).
c9s commented 7 months ago

Awesome!

c9s commented 7 months ago

Thanks!