search

c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.18k stars 283 forks source link

REFACTOR: [binance] rewrite binance depth requestgen #1528

Closed c9s closed 7 months ago

bbgokarma-bot commented 7 months ago

Welcome back! @c9s, This pull request may get 520 BBG.

bbgokarma-bot commented 7 months ago

Re-estimated karma: this pull request may get 547 BBG

bbgokarma-bot commented 7 months ago

Re-estimated karma: this pull request may get 554 BBG

bbgokarma-bot commented 7 months ago

Re-estimated karma: this pull request may get 580 BBG

codecov[bot] commented 7 months ago

Codecov Report

Attention: 70 lines in your changes are missing coverage. Please review.

Comparison is base (2f40149) 21.79% compared to head (d015670) 21.78%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1528/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1528 +/- ## ========================================== - Coverage 21.79% 21.78% -0.02% ========================================== Files 605 606 +1 Lines 43900 43931 +31 ========================================== Hits 9569 9569 - Misses 33649 33680 +31 Partials 682 682 ``` | [Files](https://app.codecov.io/gh/c9s/bbgo/pull/1528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) | Coverage Δ | | |---|---|---| | [pkg/types/sliceorderbook.go](https://app.codecov.io/gh/c9s/bbgo/pull/1528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3R5cGVzL3NsaWNlb3JkZXJib29rLmdv) | `30.08% <0.00%> (ø)` | | | [...g/exchange/binance/binanceapi/get\_depth\_request.go](https://app.codecov.io/gh/c9s/bbgo/pull/1528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL2V4Y2hhbmdlL2JpbmFuY2UvYmluYW5jZWFwaS9nZXRfZGVwdGhfcmVxdWVzdC5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/exchange/binance/futures.go](https://app.codecov.io/gh/c9s/bbgo/pull/1528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL2V4Y2hhbmdlL2JpbmFuY2UvZnV0dXJlcy5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/exchange/binance/exchange.go](https://app.codecov.io/gh/c9s/bbgo/pull/1528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL2V4Y2hhbmdlL2JpbmFuY2UvZXhjaGFuZ2UuZ28=) | `1.67% <0.00%> (-0.03%)` | :arrow_down: | | [pkg/exchange/binance/parse.go](https://app.codecov.io/gh/c9s/bbgo/pull/1528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL2V4Y2hhbmdlL2JpbmFuY2UvcGFyc2UuZ28=) | `18.65% <11.76%> (-0.81%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1528?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1528?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [2f40149...d015670](https://app.codecov.io/gh/c9s/bbgo/pull/1528?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).
bbgokarma-bot commented 7 months ago

Re-estimated karma: this pull request may get 584 BBG

bbgokarma-bot commented 7 months ago

Re-estimated karma: this pull request may get 595 BBG

bbgokarma-bot commented 7 months ago

Hi @c9s,

Well done! 600 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x87d68e91f111ef01b6d37bff136ed8949ac1326422d19c4b5c1b5b014fdeb4c3

Thank you for your contribution!