c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.18k stars 283 forks source link

FEATURE: [dca2] add metrics for dca2 #1540

Closed kbearXD closed 6 months ago

bbgokarma-bot commented 6 months ago

Welcome back! @kbearXD, This pull request may get 394 BBG.

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 428 BBG

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 15.49815% with 229 lines in your changes are missing coverage. Please review.

Project coverage is 21.63%. Comparing base (3e087e8) to head (8e22473).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1540/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1540 +/- ## ========================================== - Coverage 21.74% 21.63% -0.12% ========================================== Files 609 614 +5 Lines 44046 44305 +259 ========================================== + Hits 9579 9584 +5 - Misses 33785 34038 +253 - Partials 682 683 +1 ``` | [Files](https://app.codecov.io/gh/c9s/bbgo/pull/1540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) | Coverage Δ | | |---|---|---| | [pkg/strategy/grid2/recover.go](https://app.codecov.io/gh/c9s/bbgo/pull/1540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2dyaWQyL3JlY292ZXIuZ28=) | `18.18% <100.00%> (ø)` | | | [pkg/strategy/dca2/open\_position.go](https://app.codecov.io/gh/c9s/bbgo/pull/1540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvb3Blbl9wb3NpdGlvbi5nbw==) | `49.41% <0.00%> (ø)` | | | [pkg/strategy/grid2/grid\_recover.go](https://app.codecov.io/gh/c9s/bbgo/pull/1540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2dyaWQyL2dyaWRfcmVjb3Zlci5nbw==) | `4.05% <0.00%> (ø)` | | | [pkg/strategy/dca2/recover.go](https://app.codecov.io/gh/c9s/bbgo/pull/1540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvcmVjb3Zlci5nbw==) | `37.35% <20.00%> (ø)` | | | [pkg/strategy/common/sync.go](https://app.codecov.io/gh/c9s/bbgo/pull/1540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2NvbW1vbi9zeW5jLmdv) | `71.42% <71.42%> (ø)` | | | [pkg/strategy/dca2/state.go](https://app.codecov.io/gh/c9s/bbgo/pull/1540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvc3RhdGUuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/strategy/grid2/active\_order\_recover.go](https://app.codecov.io/gh/c9s/bbgo/pull/1540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2dyaWQyL2FjdGl2ZV9vcmRlcl9yZWNvdmVyLmdv) | `0.00% <0.00%> (-34.32%)` | :arrow_down: | | [pkg/strategy/dca2/active\_order\_recover.go](https://app.codecov.io/gh/c9s/bbgo/pull/1540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvYWN0aXZlX29yZGVyX3JlY292ZXIuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/strategy/dca2/strategy.go](https://app.codecov.io/gh/c9s/bbgo/pull/1540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvc3RyYXRlZ3kuZ28=) | `0.74% <0.00%> (-0.11%)` | :arrow_down: | | [pkg/strategy/dca2/metrics.go](https://app.codecov.io/gh/c9s/bbgo/pull/1540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvbWV0cmljcy5nbw==) | `0.00% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/c9s/bbgo/pull/1540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1540?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1540?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [3e087e8...8e22473](https://app.codecov.io/gh/c9s/bbgo/pull/1540?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).
bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 446 BBG

bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 755 BBG

bbgokarma-bot commented 6 months ago

Hi @kbearXD,

Well done! 760 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x82179d3554f53a078c17a0cd380e75c52153ef1bf93541b281b4902fab7a0610

Thank you for your contribution!