c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.18k stars 283 forks source link

FEATURE: [rebalance] add price type #1541

Closed narumiruna closed 6 months ago

bbgokarma-bot commented 6 months ago

Welcome back! @narumiruna, This pull request may get 303 BBG.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 21.73%. Comparing base (06c533f) to head (dae445a). Report is 4 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1541/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1541 +/- ## ========================================== - Coverage 21.77% 21.73% -0.04% ========================================== Files 606 607 +1 Lines 43940 44002 +62 ========================================== Hits 9566 9566 - Misses 33692 33754 +62 Partials 682 682 ``` | [Files](https://app.codecov.io/gh/c9s/bbgo/pull/1541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) | Coverage Δ | | |---|---|---| | [pkg/types/price\_type.go](https://app.codecov.io/gh/c9s/bbgo/pull/1541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3R5cGVzL3ByaWNlX3R5cGUuZ28=) | `0.00% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/c9s/bbgo/pull/1541/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1541?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1541?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [06c533f...dae445a](https://app.codecov.io/gh/c9s/bbgo/pull/1541?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).
bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 313 BBG

bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 370 BBG

bbgokarma-bot commented 6 months ago

Hi @narumiruna,

Well done! 385 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xfc1d28f63a8bfa3fe976313d217662edddf61d59590d1513cbcf5f8e23074ad6

Thank you for your contribution!