search

c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.18k stars 283 forks source link

FIX: [dca2] all the profit will use in the first order of the next round #1552

Closed kbearXD closed 6 months ago

bbgokarma-bot commented 6 months ago

Welcome back! @kbearXD, This pull request may get 217 BBG.

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 21.76%. Comparing base (7abc45e) to head (9ac8bb9).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1552/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1552 +/- ## ========================================== + Coverage 21.74% 21.76% +0.01% ========================================== Files 608 608 Lines 44014 44020 +6 ========================================== + Hits 9573 9579 +6 Misses 33759 33759 Partials 682 682 ``` | [Files](https://app.codecov.io/gh/c9s/bbgo/pull/1552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) | Coverage Δ | | |---|---|---| | [pkg/strategy/dca2/open\_position.go](https://app.codecov.io/gh/c9s/bbgo/pull/1552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvb3Blbl9wb3NpdGlvbi5nbw==) | `49.41% <90.00%> (+3.84%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1552?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1552?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [7abc45e...9ac8bb9](https://app.codecov.io/gh/c9s/bbgo/pull/1552?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).
bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 250 BBG

bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 265 BBG

bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 270 BBG

bbgokarma-bot commented 6 months ago

Hi @kbearXD,

Well done! 275 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x48174597374e61ac915a68483c41230ec33ddeb2ac24dda4706f5fdd9a7745a0

Thank you for your contribution!