c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.18k stars 283 forks source link

FEATURE: [xdepthmaker] add profit fixer #1559

Closed c9s closed 6 months ago

bbgokarma-bot commented 6 months ago

Welcome back! @c9s, This pull request may get 320 BBG.

bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 325 BBG

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 21.79%. Comparing base (88a5579) to head (26c3461). Report is 5 commits behind head on main.

:exclamation: Current head 26c3461 differs from pull request most recent head 0d3483e. Consider uploading reports for the commit 0d3483e to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1559/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1559 +/- ## ========================================== + Coverage 21.62% 21.79% +0.16% ========================================== Files 614 615 +1 Lines 44316 44372 +56 ========================================== + Hits 9584 9670 +86 + Misses 34049 34014 -35 - Partials 683 688 +5 ``` | [Files](https://app.codecov.io/gh/c9s/bbgo/pull/1559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) | Coverage Δ | | |---|---|---| | [pkg/types/profit.go](https://app.codecov.io/gh/c9s/bbgo/pull/1559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3R5cGVzL3Byb2ZpdC5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/strategy/xdepthmaker/strategy.go](https://app.codecov.io/gh/c9s/bbgo/pull/1559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L3hkZXB0aG1ha2VyL3N0cmF0ZWd5Lmdv) | `14.78% <0.00%> (-0.32%)` | :arrow_down: | | [pkg/strategy/xdepthmaker/profitfixer.go](https://app.codecov.io/gh/c9s/bbgo/pull/1559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L3hkZXB0aG1ha2VyL3Byb2ZpdGZpeGVyLmdv) | `0.00% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/c9s/bbgo/pull/1559/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1559?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1559?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [88a5579...0d3483e](https://app.codecov.io/gh/c9s/bbgo/pull/1559?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).
bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 391 BBG

bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 398 BBG

bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 413 BBG

bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 440 BBG

bbgokarma-bot commented 6 months ago

Hi @c9s,

Well done! 455 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xe0369af363e48c5909a6f93be3e046ea044dbe5bb5eeb37a48a8cee442b0b052

Thank you for your contribution!