c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.18k stars 283 forks source link

FIX: [bitget] support market order on bitget unfilled order conversion #1561

Closed bailantaotao closed 6 months ago

bailantaotao commented 6 months ago

2023/11/05 The market order will be executed immediately, so this check is used to handle corner cases. 2024/03/06 After placing a Market Order, we can retrieve it through the unfilledOrder API, so we still need to handle the Market Order status.

bbgokarma-bot commented 6 months ago

Welcome back! @bailantaotao, This pull request may get 278 BBG.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 21.99%. Comparing base (ceb3091) to head (9144580). Report is 13 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1561/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1561?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1561 +/- ## ========================================== + Coverage 21.98% 21.99% +0.01% ========================================== Files 615 615 Lines 44374 44382 +8 ========================================== + Hits 9754 9764 +10 + Misses 33927 33925 -2 Partials 693 693 ``` | [Files](https://app.codecov.io/gh/c9s/bbgo/pull/1561?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) | Coverage Δ | | |---|---|---| | [pkg/exchange/bitget/exchange.go](https://app.codecov.io/gh/c9s/bbgo/pull/1561?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL2V4Y2hhbmdlL2JpdGdldC9leGNoYW5nZS5nbw==) | `44.21% <100.00%> (+0.82%)` | :arrow_up: | | [pkg/exchange/bitget/convert.go](https://app.codecov.io/gh/c9s/bbgo/pull/1561?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL2V4Y2hhbmdlL2JpdGdldC9jb252ZXJ0Lmdv) | `93.49% <66.66%> (+0.36%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/c9s/bbgo/pull/1561/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1561?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1561?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [ceb3091...9144580](https://app.codecov.io/gh/c9s/bbgo/pull/1561?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).
bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 295 BBG

bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 300 BBG

bbgokarma-bot commented 6 months ago

Hi @bailantaotao,

Well done! 305 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x1ab8bd75b13ce47766cb6195e2368b6a4e916f25327c53fd5293f7ab5cb5d5c4

Thank you for your contribution!