search

c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.18k stars 283 forks source link

FIX: [xdepthmaker] fix crash #1566

Closed c9s closed 6 months ago

bbgokarma-bot commented 6 months ago

Welcome back! @c9s, This pull request may get 205 BBG.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 21.99%. Comparing base (f587317) to head (b6ddb49). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1566/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1566 +/- ## ========================================== - Coverage 21.99% 21.99% -0.01% ========================================== Files 615 615 Lines 44387 44402 +15 ========================================== Hits 9764 9764 - Misses 33930 33945 +15 Partials 693 693 ``` | [Files](https://app.codecov.io/gh/c9s/bbgo/pull/1566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) | Coverage Δ | | |---|---|---| | [pkg/strategy/xdepthmaker/profitfixer.go](https://app.codecov.io/gh/c9s/bbgo/pull/1566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L3hkZXB0aG1ha2VyL3Byb2ZpdGZpeGVyLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/strategy/xdepthmaker/strategy.go](https://app.codecov.io/gh/c9s/bbgo/pull/1566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L3hkZXB0aG1ha2VyL3N0cmF0ZWd5Lmdv) | `14.39% <0.00%> (-0.25%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1566?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1566?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [f587317...b6ddb49](https://app.codecov.io/gh/c9s/bbgo/pull/1566?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).
bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 231 BBG

bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 241 BBG

bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 249 BBG

bbgokarma-bot commented 6 months ago

Hi @c9s,

Well done! 254 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x823f82c42e65e351a51ba2f6592abde96c169222b459612baa81386be07cc7b1

Thank you for your contribution!