search

c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.18k stars 283 forks source link

REFACTOR: refactor profit fixer #1567

Closed c9s closed 6 months ago

bbgokarma-bot commented 6 months ago

Welcome back! @c9s, This pull request may get 408 BBG.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 21.98%. Comparing base (9a76d2e) to head (d139d33).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1567/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1567 +/- ## ========================================== - Coverage 21.99% 21.98% -0.01% ========================================== Files 615 615 Lines 44402 44410 +8 ========================================== Hits 9764 9764 - Misses 33945 33953 +8 Partials 693 693 ``` | [Files](https://app.codecov.io/gh/c9s/bbgo/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) | Coverage Δ | | |---|---|---| | [pkg/strategy/xdepthmaker/strategy.go](https://app.codecov.io/gh/c9s/bbgo/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L3hkZXB0aG1ha2VyL3N0cmF0ZWd5Lmdv) | `14.39% <0.00%> (ø)` | | | [pkg/strategy/common/profit\_fixer.go](https://app.codecov.io/gh/c9s/bbgo/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2NvbW1vbi9wcm9maXRfZml4ZXIuZ28=) | `0.00% <0.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1567?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1567?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [9a76d2e...d139d33](https://app.codecov.io/gh/c9s/bbgo/pull/1567?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).
bbgokarma-bot commented 6 months ago

Hi @c9s,

Well done! 418 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xf351338c6a4c4c9deed651d67db2075676f70bcae401b50b72e669c278537281

Thank you for your contribution!