search

c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.19k stars 290 forks source link

dca2: new struct RoundCollector for testing and use flag to decide re… #1586

Closed kbearXD closed 6 months ago

kbearXD commented 6 months ago

…covery

bbgokarma-bot commented 6 months ago

Welcome back! @kbearXD, This pull request may get 396 BBG.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 126 lines in your changes are missing coverage. Please review.

Project coverage is 22.51%. Comparing base (239f7ea) to head (a23c476).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1586/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1586 +/- ## ========================================== - Coverage 22.53% 22.51% -0.03% ========================================== Files 617 618 +1 Lines 44478 44520 +42 ========================================== Hits 10023 10023 - Misses 33740 33782 +42 Partials 715 715 ``` | [Files](https://app.codecov.io/gh/c9s/bbgo/pull/1586?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) | Coverage Δ | | |---|---|---| | [pkg/strategy/dca2/state.go](https://app.codecov.io/gh/c9s/bbgo/pull/1586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvc3RhdGUuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/strategy/dca2/recover.go](https://app.codecov.io/gh/c9s/bbgo/pull/1586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvcmVjb3Zlci5nbw==) | `37.07% <0.00%> (-1.08%)` | :arrow_down: | | [pkg/strategy/dca2/strategy.go](https://app.codecov.io/gh/c9s/bbgo/pull/1586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvc3RyYXRlZ3kuZ28=) | `0.75% <0.00%> (+0.10%)` | :arrow_up: | | [pkg/strategy/dca2/round\_collector.go](https://app.codecov.io/gh/c9s/bbgo/pull/1586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvcm91bmRfY29sbGVjdG9yLmdv) | `0.00% <0.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1586?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1586?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [239f7ea...a23c476](https://app.codecov.io/gh/c9s/bbgo/pull/1586?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).
bbgokarma-bot commented 6 months ago

Hi @kbearXD,

Well done! 406 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x228b611866f2453f4b8426560e392e3c58926a614891869349a00a78cb38dc95

Thank you for your contribution!