search

c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.16k stars 276 forks source link

FIX: [xalign] add more complex test case for xalign strategy #1593

Closed c9s closed 4 months ago

bbgokarma-bot commented 4 months ago

Welcome back! @c9s, This pull request may get 454 BBG.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 65.21739% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 22.59%. Comparing base (3e14c14) to head (aced149). Report is 2 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1593/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1593 +/- ## ========================================== + Coverage 22.53% 22.59% +0.06% ========================================== Files 618 619 +1 Lines 44528 44830 +302 ========================================== + Hits 10034 10130 +96 - Misses 33779 33973 +194 - Partials 715 727 +12 ``` | [Files](https://app.codecov.io/gh/c9s/bbgo/pull/1593?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) | Coverage Δ | | |---|---|---| | [pkg/bbgo/session.go](https://app.codecov.io/gh/c9s/bbgo/pull/1593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL2JiZ28vc2Vzc2lvbi5nbw==) | `8.22% <0.00%> (-0.03%)` | :arrow_down: | | [pkg/strategy/xalign/strategy.go](https://app.codecov.io/gh/c9s/bbgo/pull/1593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L3hhbGlnbi9zdHJhdGVneS5nbw==) | `33.80% <71.42%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/c9s/bbgo/pull/1593/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1593?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1593?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [3e14c14...aced149](https://app.codecov.io/gh/c9s/bbgo/pull/1593?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).
bbgokarma-bot commented 4 months ago

Hi @c9s,

Well done! 464 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x990b0971cc41a05cc2cd6a2ffbea25efbd0ff12a5652d41d519b5d0e4e255637

Thank you for your contribution!