c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.16k stars 276 forks source link

REFACTOR: [max] simplify max query ticker #1595

Closed c9s closed 3 months ago

bbgokarma-bot commented 4 months ago

Welcome back! @c9s, This pull request may get 462 BBG.

bbgokarma-bot commented 4 months ago

Re-estimated karma: this pull request may get 467 BBG

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 55.55556% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 22.59%. Comparing base (693b641) to head (1326ffb). Report is 10 commits behind head on main.

:exclamation: Current head 1326ffb differs from pull request most recent head d399b39. Consider uploading reports for the commit d399b39 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1595/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1595?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1595 +/- ## ========================================== + Coverage 22.57% 22.59% +0.01% ========================================== Files 619 619 Lines 44832 44833 +1 ========================================== + Hits 10122 10130 +8 + Misses 33982 33976 -6 + Partials 728 727 -1 ``` | [Files](https://app.codecov.io/gh/c9s/bbgo/pull/1595?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) | Coverage Δ | | |---|---|---| | [pkg/bbgo/session.go](https://app.codecov.io/gh/c9s/bbgo/pull/1595?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL2JiZ28vc2Vzc2lvbi5nbw==) | `8.22% <0.00%> (ø)` | | | [pkg/exchange/max/exchange.go](https://app.codecov.io/gh/c9s/bbgo/pull/1595?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL2V4Y2hhbmdlL21heC9leGNoYW5nZS5nbw==) | `0.34% <0.00%> (-0.01%)` | :arrow_down: | | [pkg/strategy/xalign/strategy.go](https://app.codecov.io/gh/c9s/bbgo/pull/1595?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L3hhbGlnbi9zdHJhdGVneS5nbw==) | `33.80% <71.42%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/c9s/bbgo/pull/1595/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1595?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1595?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [693b641...d399b39](https://app.codecov.io/gh/c9s/bbgo/pull/1595?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).
bbgokarma-bot commented 3 months ago

Re-estimated karma: this pull request may get 223 BBG

bbgokarma-bot commented 3 months ago

Hi @c9s,

Well done! 228 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x2d7d2dd23728609e58837ce6bb4029489a17a8b482d537c1e5b16a7113dafb7f

Thank you for your contribution!