search

c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.16k stars 276 forks source link

FEATURE: [dca2] when all open-position orders are filled, place the t… #1599

Closed kbearXD closed 3 months ago

kbearXD commented 4 months ago

…ake-profit order

bbgokarma-bot commented 4 months ago

Welcome back! @kbearXD, This pull request may get 286 BBG.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 12.28070% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 22.63%. Comparing base (693b641) to head (f42ef77). Report is 14 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1599/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1599 +/- ## ========================================== + Coverage 22.57% 22.63% +0.05% ========================================== Files 619 621 +2 Lines 44832 44903 +71 ========================================== + Hits 10122 10164 +42 - Misses 33982 34009 +27 - Partials 728 730 +2 ``` | [Files](https://app.codecov.io/gh/c9s/bbgo/pull/1599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) | Coverage Δ | | |---|---|---| | [pkg/strategy/dca2/state.go](https://app.codecov.io/gh/c9s/bbgo/pull/1599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvc3RhdGUuZ28=) | `0.00% <ø> (ø)` | | | [pkg/strategy/dca2/recover.go](https://app.codecov.io/gh/c9s/bbgo/pull/1599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvcmVjb3Zlci5nbw==) | `37.42% <70.00%> (+0.34%)` | :arrow_up: | | [pkg/strategy/dca2/active\_order\_recover.go](https://app.codecov.io/gh/c9s/bbgo/pull/1599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvYWN0aXZlX29yZGVyX3JlY292ZXIuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/strategy/dca2/strategy.go](https://app.codecov.io/gh/c9s/bbgo/pull/1599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvc3RyYXRlZ3kuZ28=) | `0.70% <0.00%> (-0.02%)` | :arrow_down: | | [pkg/strategy/dca2/background\_runner.go](https://app.codecov.io/gh/c9s/bbgo/pull/1599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvYmFja2dyb3VuZF9ydW5uZXIuZ28=) | `0.00% <0.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/c9s/bbgo/pull/1599/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1599?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1599?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [693b641...f42ef77](https://app.codecov.io/gh/c9s/bbgo/pull/1599?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).
bbgokarma-bot commented 3 months ago

Re-estimated karma: this pull request may get 296 BBG

bbgokarma-bot commented 3 months ago

Re-estimated karma: this pull request may get 225 BBG

bbgokarma-bot commented 3 months ago

Hi @kbearXD,

Well done! 316 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x6979709c36ab82e9e88b773d20954f1b15883a9345d19746cc02e13912ad3ffc

Thank you for your contribution!