c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.19k stars 290 forks source link

consistent config param for all sub-commands #1603

Closed lanphan closed 6 months ago

lanphan commented 6 months ago

As there is persistent flag "config" with default value in root command, we don't need to add it again in all sub commands. Already checked and run "backtest", "run" subcommands and it works

Remaining sub-commands already follow this style

bbgokarma-bot commented 6 months ago

Welcome back! @lanphan, This pull request may get 212 BBG.

bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 217 BBG

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 22.57%. Comparing base (693b641) to head (29874db).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1603/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1603 +/- ## ======================================= Coverage 22.57% 22.57% ======================================= Files 619 619 Lines 44832 44832 ======================================= Hits 10122 10122 Misses 33982 33982 Partials 728 728 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1603?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1603?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [693b641...29874db](https://app.codecov.io/gh/c9s/bbgo/pull/1603?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).
bbgokarma-bot commented 6 months ago

Hi @lanphan,

Well done! 227 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x8c4c26e462ea1583d16f4debe4545ac43f826c15f134156712311e6ace5c6856

Thank you for your contribution!