search

c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.19k stars 290 forks source link

FIX: [xalign] fix buy side max amount #1608

Closed narumiruna closed 6 months ago

bbgokarma-bot commented 6 months ago

Welcome back! @narumiruna, This pull request may get 207 BBG.

bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 225 BBG

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 22.62%. Comparing base (e010619) to head (c2c650a). Report is 3 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1608/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1608?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1608 +/- ## ========================================== - Coverage 22.64% 22.62% -0.03% ========================================== Files 620 621 +1 Lines 44884 44908 +24 ========================================== - Hits 10166 10162 -4 - Misses 33989 34014 +25 - Partials 729 732 +3 ``` | [Files](https://app.codecov.io/gh/c9s/bbgo/pull/1608?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) | Coverage Δ | | |---|---|---| | [pkg/strategy/xalign/strategy.go](https://app.codecov.io/gh/c9s/bbgo/pull/1608?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L3hhbGlnbi9zdHJhdGVneS5nbw==) | `32.52% <0.00%> (-1.28%)` | :arrow_down: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/c9s/bbgo/pull/1608/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1608?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1608?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [e010619...c2c650a](https://app.codecov.io/gh/c9s/bbgo/pull/1608?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).
bbgokarma-bot commented 6 months ago

Re-estimated karma: this pull request may get 235 BBG

bbgokarma-bot commented 6 months ago

Hi @narumiruna,

Well done! 250 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x5be209016d55aa58bd100242e62d5f07419a26c1c07c5e7188cd789a6242898c

Thank you for your contribution!