search

c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.19k stars 289 forks source link

FEATURE: [dca2] add position callback #1621

Closed kbearXD closed 5 months ago

bbgokarma-bot commented 5 months ago

Welcome back! @kbearXD, This pull request may get 228 BBG.

bbgokarma-bot commented 5 months ago

Re-estimated karma: this pull request may get 243 BBG

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 22.58%. Comparing base (64f67bd) to head (b6e7c48). Report is 24 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1621/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1621 +/- ## ========================================== - Coverage 22.61% 22.58% -0.04% ========================================== Files 621 621 Lines 44913 45010 +97 ========================================== + Hits 10159 10164 +5 - Misses 34022 34112 +90 - Partials 732 734 +2 ``` | [Files](https://app.codecov.io/gh/c9s/bbgo/pull/1621?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) | Coverage Δ | | |---|---|---| | [pkg/strategy/dca2/strategy.go](https://app.codecov.io/gh/c9s/bbgo/pull/1621?src=pr&el=tree&filepath=pkg%2Fstrategy%2Fdca2%2Fstrategy.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvc3RyYXRlZ3kuZ28=) | `0.68% <0.00%> (-0.02%)` | :arrow_down: | | [pkg/strategy/dca2/strategy\_callbacks.go](https://app.codecov.io/gh/c9s/bbgo/pull/1621?src=pr&el=tree&filepath=pkg%2Fstrategy%2Fdca2%2Fstrategy_callbacks.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2RjYTIvc3RyYXRlZ3lfY2FsbGJhY2tzLmdv) | `0.00% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/c9s/bbgo/pull/1621/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1621?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1621?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [fe53319...b6e7c48](https://app.codecov.io/gh/c9s/bbgo/pull/1621?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).
bbgokarma-bot commented 5 months ago

Hi @kbearXD,

Well done! 263 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x8f9c8e5b74db9f0dfaf7446b6e0362587b6f5561d4761c4410503d0fb63f4265

Thank you for your contribution!