c9s / bbgo

The modern cryptocurrency trading bot framework written in Go.
https://bbgo.finance
GNU Affero General Public License v3.0
1.15k stars 277 forks source link

REFACTOR: Extract and move FeeBudget from xgap #1644

Closed narumiruna closed 2 weeks ago

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 64.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 22.75%. Comparing base (5098c3a) to head (9cbf8a0). Report is 7 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/c9s/bbgo/pull/1644/graphs/tree.svg?width=650&height=150&src=pr&token=ZT7I56OV8K&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin)](https://app.codecov.io/gh/c9s/bbgo/pull/1644?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) ```diff @@ Coverage Diff @@ ## main #1644 +/- ## ========================================== + Coverage 22.71% 22.75% +0.03% ========================================== Files 619 622 +3 Lines 44697 44783 +86 ========================================== + Hits 10153 10189 +36 - Misses 33810 33855 +45 - Partials 734 739 +5 ``` | [Files](https://app.codecov.io/gh/c9s/bbgo/pull/1644?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) | Coverage Δ | | |---|---|---| | [pkg/strategy/common/fee\_budget.go](https://app.codecov.io/gh/c9s/bbgo/pull/1644?src=pr&el=tree&filepath=pkg%2Fstrategy%2Fcommon%2Ffee_budget.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin#diff-cGtnL3N0cmF0ZWd5L2NvbW1vbi9mZWVfYnVkZ2V0Lmdv) | `64.00% <64.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/c9s/bbgo/pull/1644?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/c9s/bbgo/pull/1644?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Last update [6b6bf2f...9cbf8a0](https://app.codecov.io/gh/c9s/bbgo/pull/1644?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Yo-An+Lin).