search

c9s / r3

libr3 is a high-performance path dispatching library. It compiles your route paths into a prefix tree (trie). By using the constructed prefix trie in the start-up time, you may dispatch your routes with efficiency
http://c9s.github.com/r3/bench.html
MIT License
813 stars 83 forks source link

Add Coverity Scan to CI #149

Closed bjosv closed 1 year ago

bjosv commented 2 years ago

Coverity is a static code analysis tool which can find and warn about many hard-to-find faults. This PR adds a CI job that triggers a scan, and a correction of the last existing issue.

Results will be available at: https://scan.coverity.com/projects/r3

Fixes #110

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 90.228% when pulling 04d52a6dd199d180196895e3d21d98c976fabeeb on Nordix:coverity-in-ci into 76e277030494a01147198dd4ff874bcc912a7de6 on c9s:2.0.

bjosv commented 2 years ago

@c9s If you also think this would be a good tool to run in CI then I will update the PR before it can be merged. Updates are needed to use secrets.COVERITY_TOKEN and to update the email to yours before merging this. Then I will add you as admin in the Coverity project, so that you can regenerate a token on the Coverity project webpage by the click of a button and add that as a Github secret.

c9s commented 2 years ago

@bjosv sure! let's do this

c9s commented 2 years ago

@bjosv I can add you as a collaborator of this repo ;)

bjosv commented 2 years ago

@bjosv I can add you as a collaborator of this repo ;)

It's a badge of honor, thanks :) I now added you as owner of the project in https://scan.coverity.com/projects/r3 The coverity job failed after the last change due to the missing Github secret COVERITY_TOKEN that needs to be configured in the Github project (Settings/Secret which I cant access) and it needs to be set to the Project token got from: https://scan.coverity.com/projects/r3?tab=project_settings

c9s commented 1 year ago

Sorry for the slow update! I just added the token

image