Closed czchen closed 10 years ago
Looks nice! thanks!
Merged thanks!
The r3_tree_insert_pathl
is actually a macro of _r3_tree_insert_pathl
, so I commented the regexp statement.
I think adding prefix r3
and using -export-symbols-regex
are necessary to avoid name collision problem.
In current code, some generic names like str_split
are exported. These symbols are easily cause name collision. This can be avoid by adding unique prefix.
As for testing, if testing internal functions is necessary, we can just link testing program against static library so that testing internal functions is okay.
Agree~
struct name does not need to be exported since they are just offset and size in application binary interface (ABI). As for symbol
match_entry
, updated regex will export them.The command
objdump -t libr3.so.0
can be used to see export symbols. If the second column of a symbol is marked asg
, it is exported.