search

c9s / r3

libr3 is a high-performance path dispatching library. It compiles your route paths into a prefix tree (trie). By using the constructed prefix trie in the start-up time, you may dispatch your routes with efficiency
http://c9s.github.com/r3/bench.html
MIT License
814 stars 83 forks source link

Running valgrind in a different build in order to detect memory leaks. #31

Closed thedrow closed 10 years ago

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling cd4d4647deb572b4c60d626296c356135db4dfd8 on thedrow:patch-1 into 5a84e9aeb2e28ab1ad2c2f8d1ccdcb5a6b59f497 on c9s:master.

c9s commented 10 years ago

Looks nice!

c9s commented 10 years ago

But travis ci build failed

thedrow commented 10 years ago

Because valgrind actually found an error :)

thedrow commented 10 years ago

Can you pull this so it will be part of the build process?

c9s commented 10 years ago

Hi! can you rebase this PR ? so we may know the key point of the failure.

thedrow commented 10 years ago

For some reason I can't push. Just merge this and see what happens in the next build.

c9s commented 10 years ago

Well, I guess you need to push + --force

thedrow commented 10 years ago

I did.

c9s commented 10 years ago

ok it's building https://travis-ci.org/c9s/r3/builds/25682078

c9s commented 10 years ago

since like there is a missing config for it?

./tests/.libs/check_slug: error while loading shared libraries: libr3.so.0: cannot open shared object file: No such file or directory
c9s commented 10 years ago

https://travis-ci.org/c9s/r3/jobs/25683096 there is no leaks now, but it's failed.

thedrow commented 10 years ago

There is a error: ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 2 from 2)

thedrow commented 10 years ago

See?

./tests/.libs/check_slug: error while loading shared libraries: libr3.so.0: cannot open shared object file: No such file or directory

==10605== Jump to the invalid address stated on the next line

==10605== at 0x4C6: ???

==10605== by 0x400F04A: _dl_signal_error (dl-error.c:122)

==10605== by 0x400E62A: _dl_map_object_deps (dl-deps.c:705)

==10605== by 0x400350C: dl_main (rtld.c:1827)

==10605== by 0x4015B23: _dl_sysdep_start (dl-sysdep.c:244)

==10605== by 0x4005364: _dl_start (rtld.c:338)

==10605== by 0x40016B7: ??? (in /lib/x86_64-linux-gnu/ld-2.15.so)

==10605== by 0x7: ???

==10605== by 0x7FEFFFE26: ???

==10605== by 0x7FEFFFE3F: ???

==10605== by 0x7FEFFFE58: ???

==10605== by 0x7FEFFFE74: ???

==10605== Address 0x4c6 is not stack'd, malloc'd or (recently) free'd

==10605==

==10605==

==10605== Process terminating with default action of signal 11 (SIGSEGV)

==10605== Bad permissions for mapped region at address 0x4C6

==10605== at 0x4C6: ???

==10605== by 0x400F04A: _dl_signal_error (dl-error.c:122)

==10605== by 0x400E62A: _dl_map_object_deps (dl-deps.c:705)

==10605== by 0x400350C: dl_main (rtld.c:1827)

==10605== by 0x4015B23: _dl_sysdep_start (dl-sysdep.c:244)

==10605== by 0x4005364: _dl_start (rtld.c:338)

==10605== by 0x40016B7: ??? (in /lib/x86_64-linux-gnu/ld-2.15.so)

==10605== by 0x7: ???

==10605== by 0x7FEFFFE26: ???

==10605== by 0x7FEFFFE3F: ???

==10605== by 0x7FEFFFE58: ???

==10605== by 0x7FEFFFE74: ???
c9s commented 10 years ago

yeah because the shared library: libr3 can't be found. so there is an error about _dl_* functions, can you take a look?

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 5dbef0cf24b299cec1c1e802c1e093d1293d4d5c on thedrow:patch-1 into 79fb3a3b8ad59021f55d80d6f9483fd72ca13d19 on c9s:master.

c9s commented 10 years ago

Great, let me merge this.