Closed thedrow closed 8 years ago
You may run tests/benchmark
and compare the benchmark result with the result of the master branch.
http://c9s.github.io/r3/bench.html Here is the benchmark tracking graph, you should check the graph frequently while developing. it's helpful.
What do you think about the current change?
Because it's recursive. We can have an internal function to handle that though.
you can have a r3_tree_dump_sds
function that takes the sds
struct. so r3_tree_dump_str
calls r3_tree_dump_sds
to generate the result recursively.
I still think it's OK for dumping struct through sds
(string operation outside of critical area). I don't want to replace the current dispatching functions with sds.
Hi @thedrow , Is char * text = r3_tree_dump_str(n, 0);
ready to dump? :-)
Sorry, I had a lot on my plate lately. I will get to it soon.
oh, you can take your time, it's not in a hurry. just worry about the code conflicts.
Closed since there are too many changes in 2.0 branch.
I'm going to keep this branch maintained as I'll migrate methods from char * to sds. I know you asked me to avoid doing so on certain methods so I'll migrate them one by one so you can cherry pick according to the benchmarks. Who knows? It might be faster.