c9s / r3

libr3 is a high-performance path dispatching library. It compiles your route paths into a prefix tree (trie). By using the constructed prefix trie in the start-up time, you may dispatch your routes with efficiency
http://c9s.github.com/r3/bench.html
MIT License
813 stars 83 forks source link

handle return codes, prevent segfaults #68

Closed stephenmathieson closed 10 years ago

stephenmathieson commented 10 years ago

looks like you're not checking return codes for a lot of function calls. this will cause issues in a real-world environment.

at first glance, the following in "list.c" need to report/handle failures:

...

if you like, i can fork and fix a few of these :)

c9s commented 10 years ago

Thanks, if you could send me a PR, that would be great! :)

c9s commented 10 years ago

oh I just checked, the list.c is not used for now. it was included for somewhat purpose, however it's not used. :)

c9s commented 10 years ago

I will remove that file later.

stephenmathieson commented 10 years ago

oh sorry I forgot about this. glad to hear it's not used ;)

c9s commented 10 years ago

@stephenmathieson no problem. it's welcomed to drop me any feedback at any time, thanks! :-)