search

c9s / r3

libr3 is a high-performance path dispatching library. It compiles your route paths into a prefix tree (trie). By using the constructed prefix trie in the start-up time, you may dispatch your routes with efficiency
http://c9s.github.com/r3/bench.html
MIT License
816 stars 83 forks source link

Fix pcre_exec's return type #72

Closed kanru closed 10 years ago

kanru commented 10 years ago

According to PCRE_EXEC(3) pcre_exec returns int.

The original code uses char but char could be either signed or unsigned. On armel and sparc this caused segment fault because the (rc < 0) error checking was optimized out.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 3629452fe0e249af50dea14d75dfcfd56d0abdc6 on kanru:fix-pcre-return-type into 8c5b25949ec4c2cc0cba74f413daaa4c8241e3c1 on c9s:master.

c9s commented 10 years ago

Thanks!