search

c9s / r3

libr3 is a high-performance path dispatching library. It compiles your route paths into a prefix tree (trie). By using the constructed prefix trie in the start-up time, you may dispatch your routes with efficiency
http://c9s.github.com/r3/bench.html
MIT License
813 stars 83 forks source link

Slug parse, changed memory model, few optimizations #97

Closed karantin2020 closed 8 years ago

karantin2020 commented 8 years ago

See comment to commit

karantin2020 commented 8 years ago

If it will not merge well on that branch then you can test changes on my fork with branch krn_feature

c9s commented 8 years ago

@karantin2020 I'm wondering about where the memory.h from. I saw there is a copyright "Copyright (c) 2014 DeNA Co., Ltd.", there might be a licensing issue. what's the license type?

karantin2020 commented 8 years ago

see https://github.com/h2o/h2o MIT license

Names of function were changes because of conflicts with that lib

I just use my branch of r3 and h2o for my use cases Soon I will publish that repo

karantin2020 commented 8 years ago

krn_feature branch merged. Close PR

c9s commented 8 years ago

Hi @karantin2020 there is a build error after merging your changes, could you take a look please? otherwise I might have to revert the merge to make keep the build status stable.

karantin2020 commented 8 years ago

Error in commit "Clean heap after use in simple example"?

karantin2020 commented 8 years ago

I tested now current branch 2.0. Everything compiles well, all tests done. What kind of error do you have?

In commits comment I wrote that few API was changed

c9s commented 8 years ago

Sorry I forgot to paste the travis ci url, one moment

c9s commented 8 years ago

https://travis-ci.org/c9s/r3

karantin2020 commented 8 years ago

Travis log above shows only error in "Clean heap after use in simple example". Current travis error is in "Fix fprintf warning" commit.

All tests and examples execute well.

What is the error reason? May be travis config?

Travis log shows error in "r3 core tests" suite (endless execution). On my local machine everything works fine. Did you find anything else?