search

c9s / typeloy

typeloy is a meteor application deployment tool written in typescript.
MIT License
25 stars 8 forks source link

Kudos + Nginx www domain redir #57

Open lfilho opened 8 years ago

lfilho commented 8 years ago

Hi there, @c9s thanks for your work!

I was about to fork https://github.com/dtsepelev/meteor-up-letsencrypt when I saw your project. Looking good.

The reason why I was going to fork it is so I could customize the nginx template file in order to support redirs from www to non-www versions. Right now when users access my www.domain.com it errors out and they are left thinking my site is offline. Of course it is running fine in domain.com.

Does typeloy support that? Or how easy would it be to support it? I'm happy to contribute but bear in mind that i'm still learning nginx/servers world (i'm mainly a frontend dev with basic knowledge on docker, shell, etc).

Thanks!!

c9s commented 8 years ago

Hi @lfilho

We have certbot auto-installer, and basically you can just provide an email and a domain to register the ssl.

Right now we don't have nginx support but I think we should have this done. :p. the config structure needs to changed a little bit.

PRs are welcome!

c9s commented 8 years ago

Using template that generates the corresponding nginx config shouldn't be hard, we just need to define the structure.