/- validate all 4 required data source parameters are present (including url)
use error logging and exception throwing instead of assert()
instead of exiting with error, log a warning if deprecated properties are set
(the deprectaed properties are currently needed by the msk importer)
This change is needed because the msk importer currently requires the deprecated parameters:
db.user, db.password, db.connection_string, db.portal_db_name, db.host, db.driver
This PR also cleans up the code, providing functions for:
logging warnings for use of deprecated datasource properties
validating the presence of 4 required datasource properties (spring.datasource.url was added)
stringIsNullOrBlank
According to the final section notes of https://docs.oracle.com/javase/specs/jls/se7/html/jls-14.html#jls-14.10 it is bad practice to handle invalid argument problems through assert() because assert processing is disabled by default but validity of arguments should be checked regardless of whether assertions are enabled or not. Also, an appropriate exception is not thrown by assert(), which causes an AssertionError to be thrown instead. For these reasons, assert() was replaced by throw new RuntimeException(), which causes the construction of the datasource bean to fail during the bean construction stage of context creation, exiting the application.
Note : this PR replaced #26 because currently, pull requests across forks seems to cause a failure in the CI tests (updating dependencies in the manifest / maven.yml)
/- validate all 4 required data source parameters are present (including url)
This change is needed because the msk importer currently requires the deprecated parameters: db.user, db.password, db.connection_string, db.portal_db_name, db.host, db.driver
The change of the Assert() statement into a logged warning in JdbcDataSource.java was approved and merged into the cbioportal codebase previously with https://github.com/cBioPortal/cbioportal/pull/10424
This PR also cleans up the code, providing functions for:
According to the final section notes of https://docs.oracle.com/javase/specs/jls/se7/html/jls-14.html#jls-14.10 it is bad practice to handle invalid argument problems through assert() because assert processing is disabled by default but validity of arguments should be checked regardless of whether assertions are enabled or not. Also, an appropriate exception is not thrown by assert(), which causes an AssertionError to be thrown instead. For these reasons, assert() was replaced by throw new RuntimeException(), which causes the construction of the datasource bean to fail during the bean construction stage of context creation, exiting the application.
Note : this PR replaced #26 because currently, pull requests across forks seems to cause a failure in the CI tests (updating dependencies in the manifest / maven.yml)