search

cBioPortal / cbioportal

cBioPortal for Cancer Genomics
https://cbioportal.org
GNU Affero General Public License v3.0
644 stars 504 forks source link

Issue with Number at Risk table in survival tab #10669

Closed alisman closed 8 months ago

alisman commented 8 months ago

Ordering of groups in the Number at Risk table of survival chart seems incorrect.

Go to this link.

Note in the before and after e2e test how the groups at point 0 have changed. I believe this is due to a problem in the sorting/ordering logic. This maybe have been exposed by an update to data. The fact that the chart above is stable suggests that this is a code problem which makes the output dependent on arbitrary order of data.

Before: image

After: image

alisman commented 8 months ago

Maybe misunderstanding but there still seems like a problem when comparing chart with table: image

alisman commented 8 months ago

@inodb and @dippindots i'm still seeing a discrepancy between the chart and the table after Tim's fix.

See the screenshot in my last comment. Is there any other reason these numbers might not match up? Censoring?