search

cBioPortal / cbioportal

cBioPortal for Cancer Genomics
https://cbioportal.org
GNU Affero General Public License v3.0
581 stars 448 forks source link

Confirmation message in ad chart interface causes dropdown to widen unpleasantly #10737

Closed alisman closed 2 months ago

alisman commented 3 months ago

Depending on the length of the name of the chart added, the dropdown is forced to open wider. It then suddently jumps back when message disappears. Perhaps we should simplify this by notifying user with a toast message:

image

image

mhsh312 commented 3 months ago

How about defining a max-width for the confirmation message so that the message box increases in height extra text just goes to the next line?

alisman commented 3 months ago

@mhsh312 the menu as a whole needs to be flexible width. the confirmation message should always fill but never push out the menu. this should be possible with css. give it a shot! thanks!

mhsh312 commented 3 months ago

@alisman so are you saying that when the message is too big and wants more space, the whole menu should grow out instead of just the message?

alisman commented 3 months ago

No, i want the message text to wrap and grow vertically when necessary. It should not cause the menu to expand horizontally.

On Fri, Apr 12, 2024 at 1:01 PM mhsh312 @.***> wrote:

@alisman https://github.com/alisman so are you saying that when the message is too big and wants more space, the whole menu should grow out instead of just the message?

— Reply to this email directly, view it on GitHub https://github.com/cBioPortal/cbioportal/issues/10737#issuecomment-2052136757, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABNRGMMMCBK6IQ5G3OYMXTY5AHP5AVCNFSM6AAAAABFXXP6FGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJSGEZTMNZVG4 . You are receiving this because you were mentioned.Message ID: @.***>

mhsh312 commented 3 months ago

Ok, makes sense. I will make some css changes to the SuccessBanner component and that should fix it.