cBioPortal / cbioportal

cBioPortal for Cancer Genomics
https://cbioportal.org
GNU Affero General Public License v3.0
581 stars 448 forks source link

Enable multi-study study-view cache #10764

Closed kalletlak closed 2 months ago

kalletlak commented 2 months ago

Fix https://github.com/cBioPortal/cbioportal/issues/10746

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

inodb commented 2 months ago

Let's wait for Aaron to look this over. We should also monitor the redis cache when we deploy this (how much does this increase the memory footprint? How often are we clearing existing keys etc)

alisman commented 2 months ago

@kalletlak @jjgao @inodb i think we limited it to single study queries because we worried about permutations of studies overwhelming cache. probably should have tried it first to see if there was a problem. anyway, we can merge this but we should perhaps monitor the cache for the public portal to see if this changes things dramatically