cBioPortal / cbioportal

cBioPortal for Cancer Genomics
https://cbioportal.org
GNU Affero General Public License v3.0
631 stars 480 forks source link

(rebased) Refactor sort/search/pagination for ClinicalData table endpoint #10766

Closed dippindots closed 5 months ago

dippindots commented 5 months ago

Fix # (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

Checks

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging policy. It can help to figure out who worked on the file before you. Please use git blame <filename> to determine that and notify them either through slack or by assigning them as a reviewer on the PR

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

JREastonMarks commented 5 months ago

Weren't most, if not all, of these fixed with @fuzhaoyuan PR?

inodb commented 5 months ago

Correct @JREastonMarks - I think this is superseded by: https://github.com/cBioPortal/cbioportal/pull/10407