follow up fixes pagination PRs

inodb commented 5 months ago

[x] after going to 500 and pressing show more the behavior is not super obvious. It keeps adding records it seems to how all 1-500? Not sure if this is intended

Disable 'show more' when this message appears
[x] This banner only shows when using next page all the way to the last page. I assume it also needs to be displayed when you click 'Show more' until the maximum records.

~- [ ] fix for multistudy queries, e.g. this example~

[ ] Increase default 500 limit to be higher based on testing (should not take more than a second or so, maybe 5K?)
[ ] sorting of table is broken
- [ ] It's only broken with Patient ID, Sample ID and Cancer Study columns
- [ ] Here is a broken record

fuzhaoyuan commented 5 months ago

@inodb I discussed with Jeremy and he thinks it may be good to have: 1) A parameter of the table to set different limit other than 500 2) Somewhere around the table to inform user of the limit existance What do you think?

inodb commented 5 months ago

Thanks @fuzhaoyuan !

Based on yesterday's discussion, we can increase the default limit substantially beyond 500 based on how fast it responds (maybe 5K?). It's a bit slow getting all data here: https://www.cbioportal.org/study/clinicalData?id=msk_impact_2017. Added it to the checklist at the top

I think 1 & 2 makes sense but will require new UI. So I'd vote to first get this out in a way not/hardly noticeable to users and then have a follow-up PR that improves UI

fuzhaoyuan commented 4 months ago

Do we want to make this banner ClinicalDataTab specific or keep if generic in the LazyMobXTable?

cBioPortal / cbioportal

follow up fixes pagination PRs #10770